-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apis: add Recommendation crd #1937
apis: add Recommendation crd #1937
Conversation
b8981c3
to
a07f07f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1937 +/- ##
==========================================
+ Coverage 67.23% 67.47% +0.24%
==========================================
Files 410 420 +10
Lines 45662 46858 +1196
==========================================
+ Hits 30702 31619 +917
- Misses 12742 12939 +197
- Partials 2218 2300 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a07f07f
to
80ab2b3
Compare
80ab2b3
to
aa5f6eb
Compare
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
aa5f6eb
to
591eac4
Compare
/lgtm @songzh215 please take a look this API. |
Co-authored-by: Zach Zhu <zzqshu@126.com> Signed-off-by: zwzhang <zzw261520@alibaba-inc.com>
64c0a76
to
71a41b2
Compare
/lgtm |
@zxustc: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com> Signed-off-by: zwzhang <zzw261520@alibaba-inc.com> Co-authored-by: Zach Zhu <zzqshu@126.com>
Ⅰ. Describe what this PR does
define the recommendation crd for resource prediction, see #1875 for full story.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test